Skip to content

Enable raw reads sharing by default#6660

Draft
maverbiest wants to merge 2 commits into
mainfrom
file-sharing-test
Draft

Enable raw reads sharing by default#6660
maverbiest wants to merge 2 commits into
mainfrom
file-sharing-test

Conversation

@maverbiest

@maverbiest maverbiest commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Related to #4347

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

🚀 Preview: https://file-sharing-test.loculus.org

@claude claude Bot added the deployment Code changes targetting the deployment infrastructure label Jun 12, 2026
@claude

claude Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This PR may be related to: #4347 (Raw read epic)

@maverbiest maverbiest added the preview Triggers a deployment to argocd label Jun 12, 2026
@maverbiest

maverbiest commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Initial testing after enabling file sharing for all organisms

This is some testing I did before any code changes, just after flipping on file sharing (Raw reads) for all organisms.

I was able to attach raw reads to one of the west-nile virus example data by submitting via the web interface using the following directory structure:

➜  scratch tree west_nile_files_submission
west_nile_files_submission
└── test_INYO_2_2011
    └── ERR17072040.fastq.gz

The raw reads file I'm using belongs to one of the west-nile sequences we have on PPX: https://pathoplexus.org/seq/PP_006UYBK.2

I tried this as both the testuser and the superuser, the file gets uploaded to S3 in both cases and registered in the files table:

grafik

...and also attached to the submissions in the sequence_entries table:
grafik

However, I don't see them getting attached to the submissions in the sequence_entries_preprocessed_data table. Here, I just see the annotation files generated by prepro:

grafik

I also don't see them on the sequence details page in the website (presumably because files don't get registered on the processed data entry?)

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Code changes targetting the deployment infrastructure preview Triggers a deployment to argocd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant