feat(website): clarify submit/approve workflow labels#6679
Draft
theosanderson wants to merge 5 commits into
Draft
feat(website): clarify submit/approve workflow labels#6679theosanderson wants to merge 5 commits into
theosanderson wants to merge 5 commits into
Conversation
Update the submission review page header from 'Review current submissions' to 'Review pending submissions' to more accurately describe the page, which shows submissions awaiting review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
theosanderson
changed the title
…val)' Change the submit-page form button text from 'Submit sequences' to 'Upload (and proceed to Approval)' to make the two-step submit/approve workflow clearer. The revise page keeps the 'Submit sequences' label. Update unit and integration tests to match the new button text, and update integration test heading assertions to the renamed review page title 'Approve pending submissions'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
theosanderson
changed the title
theosanderson
added
preview
Change 'Upload (and proceed to Approval)' to 'Upload and proceed to Approval'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the wording of the sequence submission → approval workflow on the website, making the two-step nature of the process explicit:
Submit page — the form's primary action button is relabelled from "Submit sequences" to "Upload (and proceed to Approval)". This signals that uploading is the first step and is followed by an approval step, rather than implying the action immediately finalises the submission. The button on the revise page keeps the existing "Submit sequences" label (the change is scoped to
action === 'submit').Review/approval page — the page heading is renamed from "Review current submissions" to "Approve pending submissions", matching the language above and better describing the page, which lists submissions awaiting approval.
Changes
website/src/components/Submission/DataUploadForm.tsx: submit-page button text is now conditional —'Upload (and proceed to Approval)'for the submit action,'Submit sequences'for revise.website/src/pages/[organism]/submission/[groupId]/review.astro:SubmissionPageWrappertitle →'Approve pending submissions'(rendered as the page<h1>).website/src/components/Submission/SubmissionForm.spec.tsx: unit test button-name lookups updated to the new label.integration-tests/: updated the submit-page button name in the page object and submission flow spec, and updated review-page heading/text assertions across the affected specs to'Approve pending submissions'.Verification
npm run check-types— passes (0 errors)npm run format— clean (website + integration-tests)CI=1 npm run test src/components/Submission/SubmissionForm.spec.tsx— 13 passedThese are user-facing copy changes plus the corresponding test updates; no application behavior changes.
🤖 Generated with Claude Code
🚀 Preview: https://review-pending-submission.loculus.org