Skip to content

Conversation

helpau
Copy link
Contributor

@helpau helpau commented Sep 27, 2025

Cloning time: before-266 seconds, after-58 seconds, folder size: before-984 MB, after-619 MB

@helpau helpau requested a review from ckrause as a code owner September 27, 2025 17:49
@ckrause
Copy link
Contributor

ckrause commented Sep 27, 2025

The git history is needed to collect the latest added program IDs:

UIDSet SequenceProgram::collectLatestProgramIds(size_t max_commits,

The miner uses this information to prefer mutating recently added programs. This accelerates the mining process.

@helpau
Copy link
Contributor Author

helpau commented Sep 28, 2025

The git history is needed to collect the latest added program IDs:

UIDSet SequenceProgram::collectLatestProgramIds(size_t max_commits,

The miner uses this information to prefer mutating recently added programs. This accelerates the mining process.

Fixed. What do you think about current version of PR?

Copy link
Contributor

@ckrause ckrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include stats.hop in git.cpp. Replace the "fast" parameter by an int parameter for the number of commits. The default should be -1 which means full clone. Check where the clone function is called and explicitly set the parameter to the new constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants