Skip to content

UX: Support quick addition of models. #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Emt-lin
Copy link
Contributor

@Emt-lin Emt-lin commented Apr 27, 2025

Support quick addition of models. see:

CleanShot 2025-04-27 at 23 15 41

@Emt-lin
Copy link
Contributor Author

Emt-lin commented Apr 27, 2025

@logancyang wait review.

@logancyang
Copy link
Owner

logancyang commented May 1, 2025

SCR-20250430-rtpl

Thanks for the PR. Have you tested locally? This image is what I see when checking out your branch, clicking "add model" and the verification errors pop out despite having the correct keys.

Also styling related

  • The button "Add model" doesn't have any breathing room
  • Have you checked how it looks on mobile? Including a screenshot would be nice

@logancyang
Copy link
Owner

Also can you resubmit the revised PR to the preview repo, thanks!

@Emt-lin
Copy link
Contributor Author

Emt-lin commented May 2, 2025

Also can you resubmit the revised PR to the preview repo, thanks!

ok

@Emt-lin
Copy link
Contributor Author

Emt-lin commented May 2, 2025

Have you tested locally?
yeah. are you enable encrypted optin. maybe I forgot to test that the encrypted keyle already existed.

The button "Add model" doesn't have any breathing room

I also use same style as verify butto on. Before, this style was changed by zero

Have you checked how it looks on mobile? Including a screenshot would be nice.

I will add screenshot.

What does it mean "Add the currently selected mode"?

it means "Adds the model currently selected by the drop-down box"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants