Skip to content

Conversation

@j4s0nmo0n
Copy link

Hello Logan,

As we discussed, there is the pull request I would like to make about DNS and computer adding features.
Hope it helps.

Regards

@logangoins
Copy link
Owner

Wow, absolutely amazing work. Honestly, this is fantastic! The DNS stuff you implemented is really cool! Give me some time to test this :)

@logangoins
Copy link
Owner

logangoins commented Dec 5, 2025

I had a chance to review the changes today, and I have to say: I was genuinely surprised at how seamless the changes were, and how all the new changes just appeared to work without any feedback from my side! Every change/new addition I tested worked entirely perfectly and fits within the project well, and that's saying something considering the sheer amount of code added in this commit 😅 .

As I mentioned before, most of these changes were changes I already wanted to add but hadn't had the chance to sit down and develop them, so again, thank you for this contribution and fantastic work!

Before I merge I do have one question: When using a DNS A record add operation, why does the record not populate immediately within the DNS manager on the DC? It populates eventually perfectly fine, but takes a small amount of time, About a minute or so. Do you happen to know why records added via normal LDAP (Dirk-Jan's dnstool.py) are registered quicker domain-wide compared to the ADWS additions here?

@j4s0nmo0n
Copy link
Author

j4s0nmo0n commented Dec 10, 2025

Hi,

That's a good question. The main difference between an entry we create and an entry created by dnstool is the DNSTombstoned value that is set by dnstool on the entry. My guess is, when we create the DNS record with SOAPy, we currentlty do not use DNSTombstone attribute on purpose (I encountered some errors I am trying to figure out).

While creating the node, the dnstool.py script explicitly sets dNSTombstoned = False on the object. This LDAP operation appears to trigger the notifications and side effects required by the DNS service to refresh its in-memory state immediately.
A probable cause for the timing difference is that our update via ADWS does not invoke the same immediate notification or downstream effect on the DNS service as a direct LDAP modification. As a result, the DNS service eventually notices the change only during its own polling or processing cycle, typically after an interval of about 60 seconds, hence the delayed appearance.

That is the explanation I could give. I am trying to reproduce DNS entry while adding dNSTombstoned without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants