-
Notifications
You must be signed in to change notification settings - Fork 13
Add Battle.Net Services #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This can probably be cleaned up a bit, but I wasn't sure how. Each region uses the same syntax and pattern, however all URIs have a different sub-domain. I implemented it as a base class and overrides for the region, but ideally it should be a single class that can take a region setting. I wasn't sure how to tackle such a thing consistent with the architectural objectives of the project though.
Thank you for the push. I will refactor your classes and add to rep soon. |
I was looking at the unit tests but wasn't sure what was needed. Sadly my php skills are a bit rusty. Sent from my Verizon Wireless 4G LTE smartphone -------- Original message -------- Thank you for the push. I will refactor your classes and add to rep soon. — |
:), ok I understand. I will add tests too. |
Hey @AJH16. Can you please validate refactored BattleNet service. Also, I need a valid credentials to write an example and test it, can you please provide it to me? |
I will look in to it but I'm not sure that there are any sample credentials available. Sent from my Verizon Wireless 4G LTE smartphone -------- Original message -------- Hey @AJH16. Can you please validate refactored BattleNet service. Also, I need a valid credentials to write an example and test it, can you please provide it to me? — |
@AJH16 any news on this? |
Not yet, my contact has been pretty busy. I'll let you know as soon as I know anything more. Sent from my Verizon Wireless 4G LTE smartphone -------- Original message -------- @AJH16 any news on this? — |
Ok, [email protected] and phpuser123 are now valid credentials for the oAuth. I don't have an API key configured as those have to be tied to the specific callback address you are using (which also has to be an SSL secured URL. |
@AJH16 Security question/code? |
Figures. I'll set a security question for it or see if I can disable the check. Sent from my Verizon Wireless 4G LTE smartphone -------- Original message -------- @AJH16 Security question/code? — |
Ok, I waiting for it. |
ok, do the question and the answer is "wow" for the security question. |
were you able to get past the check? |
Hey @AJH16, just was a busy. I added an example to /examples, but when I tested how a service works I found an error. Here is what Battle.Net service returns: error:invalid_request Can you please test a service and fix it, if it contains an error? |
This can probably be cleaned up a bit, but I wasn't sure how. Each
region uses the same syntax and pattern, however all URIs have a
different sub-domain. I implemented it as a base class and overrides
for the region, but ideally it should be a single class that can take a
region setting. I wasn't sure how to tackle such a thing consistent
with the architectural objectives of the project though.