Skip to content

Add Battle.Net Services #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Battle.Net Services #19

wants to merge 1 commit into from

Conversation

AJH16
Copy link

@AJH16 AJH16 commented Apr 29, 2015

This can probably be cleaned up a bit, but I wasn't sure how. Each
region uses the same syntax and pattern, however all URIs have a
different sub-domain. I implemented it as a base class and overrides
for the region, but ideally it should be a single class that can take a
region setting. I wasn't sure how to tackle such a thing consistent
with the architectural objectives of the project though.

This can probably be cleaned up a bit, but I wasn't sure how.  Each
region uses the same syntax and pattern, however all URIs have a
different sub-domain.  I implemented it as a base class and overrides
for the region, but ideally it should be a single class that can take a
region setting.  I wasn't sure how to tackle such a thing consistent
with the architectural objectives of the project though.
@logical-and
Copy link
Owner

Thank you for the push. I will refactor your classes and add to rep soon.
Also, can you add please unit testing for your classes?

@AJH16
Copy link
Author

AJH16 commented Apr 29, 2015

I was looking at the unit tests but wasn't sure what was needed. Sadly my php skills are a bit rusty.

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message --------
From: And [email protected]
Date:04/29/2015 10:48 AM (GMT-05:00)
To: logical-and/php-oauth [email protected]
Cc: AJH16 [email protected]
Subject: Re: [php-oauth] Add Battle.Net Services (#19)

Thank you for the push. I will refactor your classes and add to rep soon.
Also, can you add please unit testing for your classes?


Reply to this email directly or view it on GitHub.

@logical-and
Copy link
Owner

:), ok I understand. I will add tests too.

@logical-and
Copy link
Owner

Hey @AJH16. Can you please validate refactored BattleNet service. Also, I need a valid credentials to write an example and test it, can you please provide it to me?

@AJH16
Copy link
Author

AJH16 commented May 26, 2015

I will look in to it but I'm not sure that there are any sample credentials available. 
For limited testing a new account should work but I'm not directly affiliated with BattleNet so they might shut down such an account. I do have a friend on the api team there though, so I will check with him about it. 

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message --------
From: And [email protected]
Date: 05/26/2015 2:25 PM (GMT-05:00)
To: logical-and/php-oauth [email protected]
Cc: AJH16 [email protected]
Subject: Re: [php-oauth] Add Battle.Net Services (#19)

Hey @AJH16. Can you please validate refactored BattleNet service. Also, I need a valid credentials to write an example and test it, can you please provide it to me?


Reply to this email directly or view it on GitHub.

@logical-and
Copy link
Owner

@AJH16 any news on this?

@AJH16
Copy link
Author

AJH16 commented May 28, 2015

Not yet,  my contact has been pretty busy. I'll let you know as soon as I know anything more. 

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message --------
From: And [email protected]
Date: 05/28/2015 3:33 PM (GMT-05:00)
To: logical-and/php-oauth [email protected]
Cc: AJH16 [email protected]
Subject: Re: [php-oauth] Add Battle.Net Services (#19)

@AJH16 any news on this?


Reply to this email directly or view it on GitHub.

@AJH16
Copy link
Author

AJH16 commented Jun 2, 2015

Ok, [email protected] and phpuser123 are now valid credentials for the oAuth. I don't have an API key configured as those have to be tied to the specific callback address you are using (which also has to be an SSL secured URL.

@logical-and
Copy link
Owner

@AJH16 Security question/code?

@AJH16
Copy link
Author

AJH16 commented Jun 12, 2015

Figures. I'll set a security question for it or see if I can disable the check. 

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message --------
From: And [email protected]
Date: 06/12/2015 2:54 PM (GMT-05:00)
To: logical-and/php-oauth [email protected]
Cc: AJH16 [email protected]
Subject: Re: [php-oauth] Add Battle.Net Services (#19)

@AJH16 Security question/code?


Reply to this email directly or view it on GitHub.

@logical-and
Copy link
Owner

Ok, I waiting for it.

@AJH16
Copy link
Author

AJH16 commented Jun 12, 2015

ok, do the question and the answer is "wow" for the security question.

@AJH16
Copy link
Author

AJH16 commented Jul 8, 2015

were you able to get past the check?

logical-and added a commit that referenced this pull request Jul 9, 2015
@logical-and
Copy link
Owner

Hey @AJH16, just was a busy. I added an example to /examples, but when I tested how a service works I found an error. Here is what Battle.Net service returns:

error:invalid_request
error_description:Internal server error

Can you please test a service and fix it, if it contains an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants