fix: cover traffic leaking channels - #3
Merged
Conversation
Port of vacp2p/nim-libp2p#2407. The `slot exhaustion` test now stops mix nodes before destNode. Previously (LIFO defer order), destNode stopped first, leaving in-flight exit→destNode channels in a partially-open state when the mix nodes' switches finally cleaned up. Also: NoReplyProtocol's LPStreamError handler swallows the error with `discard` instead of `raiseAssert`, since the stream can be closed concurrently while the read is in progress.
chaitanyaprem
changed the title
Collaborator
Author
|
Merging as this has already been reviewed in libp2p and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of vacp2p/nim-libp2p#2407.
The
slot exhaustiontest now stops mix nodes before destNode (so destNode shuts down last). The previous LIFO defer order left in-flight exit→destNode channels in a partially-open state when the mix switches cleaned up.NoReplyProtocol'sLPStreamErrorhandler swallows withdiscardinstead ofraiseAssert— the stream can close concurrently while the read is in progress.2 files changed, 6 insertions, 6 deletions.