fix(build): re-run logos-delivery build script when the native lib apears - #197
Merged
Conversation
mchenani
force-pushed
the
mch/fix/logos-delivery-build-order
branch
from
August 4, 2026 18:23
c2dcd8e to
2d86c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
chat-clifailing to link with undefined_logosdelivery_*symbols when the native lib is built after the firstcargo build. The build script now watches theLOGOS_DELIVERY_LIB_DIRpath so it re-runs once the lib appears, making build order irrelevant; the fallbacknixbuild also enables flakes inline, and theREADMEleads with nix develop.