feat: use upstream logos delivery rust bindings for the embedded delivery node - #200
Draft
kaichaosun wants to merge 5 commits into
Draft
feat: use upstream logos delivery rust bindings for the embedded delivery node#200kaichaosun wants to merge 5 commits into
kaichaosun wants to merge 5 commits into
Conversation
kaichaosun
changed the title
kaichaosun
force-pushed
the
delivery-rust-bindings
branch
from
August 6, 2026 11:30
71583d8 to
d46ad6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #196
Upstream patches: logos-messaging/logos-delivery-rust-bindings#132
Changes
extensions/logos-delivery-bindings, an embedded logos-delivery nodebuilt on the upstream
waku-bindingsgenerated FFI, and points thelogos-deliveryworkspace dependency at it.embedded-logos-deliveryis untouched — the new crate exposes the same publicAPI, so the switch is one line in the root
Cargo.toml.waku-bindingsat 06a7d52, which carries the multiaddr bump thatremoves the yanked
core2from the graph.extensions/logos-delivery-rustis left in place, now unused.Verified:
chat-clibuilds, workspace tests pass, and twoprobenodesexchange a message over
logos.dev.Blockers
The increased build time in CI with nim deps and build from source.
The first run of local build takes quite long too.
cc @Ivansete-status