feat(conf): default --entry-layer to kernel - #4076
Draft
igor-sirotin wants to merge 1 commit into
Draft
Conversation
The node binary is most often run as a transport-only service/fleet node, so `logosdeliverynode` no longer mounts the messaging client and reliable channel manager unless asked. Protocol flags are unchanged in the default case: the individual CLI defaults already match what `applyMode(Core)` was setting. Only the CLI default moves. `LogosDelivery.new(entryLayer = ...)` and `parseLogosDeliveryConf` keep defaulting to `channels`, so the Nim and C library entry points are unaffected. `MessagingClientConf.toWakuNodeConf` pins `entryLayer = channels` for the same reason it already pins `mode`: a conf derived from a messaging config is by construction not kernel-only.
igor-sirotin
force-pushed
the
conf/default-entry-layer-kernel
branch
from
July 28, 2026 21:28
c903ff2 to
5fd3a25
Compare
|
You can find the images built from this PR at Built from 3e82e72 |
Ivansete-status
approved these changes
Jul 31, 2026
Ivansete-status
left a comment
Ivansete-status
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I just added a minor nit. Go ahead if you feel confident about it.
Cheers.
| conf.mode = mode | ||
| # Derived from a `MessagingClientConf`, so never kernel-only: don't inherit the | ||
| # CLI default. `LogosDeliveryConf.init` overwrites this with the caller's layer. | ||
| conf.entryLayer = EntryLayer.channels |
Collaborator
There was a problem hiding this comment.
Should the level be "messaging" in this case? ( I might be missing something .)
igor-sirotin
marked this pull request as draft
July 31, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flips the
--entry-layerdefault fromchannelstokernel, so the node runstransport-only unless asked otherwise.
--entry-layer=channelsrestores the oldbehaviour.
Protocol flags are unchanged — the individual CLI defaults already match what
applyMode(Core)was setting. Gone by default: messaging client, reliablechannel manager, messaging REST endpoints.
Only the CLI default moves;
LogosDelivery.newandparseLogosDeliveryConfstill default to
channels.Changes
cli_args:entryLayerdefaults tokernel.messaging_conf:toWakuNodeConfpinsentryLayer = channels, so a confderived from a
MessagingClientConfdoesn't inherit the new CLI default.api_exampleopts intochannels; test for the new default.