refactor(codegen): Rust crate names follow native=bare / cbor=_cbor - #66
Draft
Ivansete-status wants to merge 1 commit into
Draft
refactor(codegen): Rust crate names follow native=bare / cbor=_cbor#66Ivansete-status wants to merge 1 commit into
Ivansete-status wants to merge 1 commit into
Conversation
…nvention Aligns the Rust crate names with the C generator and the symbol naming: the native (zero-serialization, same-process) crate is the bare `<lib>` and the CBOR (inter-process) crate carries the `_cbor` suffix — mirroring `<lib>.h` / `<lib>_cbor.h` and the `<name>` / `<name>_cbor` exports. Previously the native crate was `<lib>_native` and the CBOR crate was the bare `<lib>`, which is backwards from the symbol convention. Only the Cargo package name changes; the linked dylib stays `lib<lib>.dylib` (the `#[link]` name and build.rs are untouched). Consumers updated: rust_client depends on `my_timer_cbor` and imports from it; the native demo imports from the bare `my_timer`. Validated: rust_client builds against the renamed CBOR crate; the native demo round-trips version / echo / event / complex / schedule against the bare crate; check_bindings_rust regen is deterministic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reconciles the Rust crate names with the C generator and the symbol naming. The native (zero-serialization, same-process) crate is the bare
<lib>; the CBOR (inter-process) crate carries the_cborsuffix — mirroring<lib>.h/<lib>_cbor.hand the<name>/<name>_cborexports.Previously the native crate was
<lib>_nativeand the CBOR crate was the bare<lib>— backwards from the convention. Only the Cargo package name changes; the linked dylib stayslib<lib>.dylib(the#[link]name and build.rs are untouched).Consumers updated:
rust_clientdepends onmy_timer_cborand imports from it; the native demo imports from the baremy_timer.Test
rust_clientbuilds against the renamed CBOR crate.check_bindings_rustregen is deterministic.Stacked on #64.
🤖 Generated with Claude Code