Skip to content

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jun 30, 2025

Three concerns are mixed in this PR, I can split them into separate PRs if the reviewer so wishes:

  1. change the mirror from where to download kafka for testing
  2. DRY the kafka version location to ensure tests run with the same kafka broker version as the client
  3. use a better set of curl flags to maintain error messages and still avoid flooding ci logs with download progress

@jsvd jsvd force-pushed the change_mirror_location branch from 04b4ef1 to 7333ff8 Compare July 3, 2025 08:57
@jsvd jsvd force-pushed the change_mirror_location branch from 7333ff8 to 1d612ed Compare July 3, 2025 08:58
@jsvd jsvd marked this pull request as ready for review July 3, 2025 08:59
@jsvd jsvd requested a review from yaauie July 3, 2025 09:00
@jsvd jsvd changed the title change to new mirror change to new mirror, dry kafka version, better curl flags Jul 3, 2025
@jsvd jsvd requested a review from kaisecheng October 16, 2025 09:19
@jsvd
Copy link
Member Author

jsvd commented Oct 16, 2025

@kaisecheng since you're deep into the kafka plugin code, maybe you can review this? thanks

@kaisecheng
Copy link
Contributor

@jsvd kafka_test_setup.sh has defined KAFKA_VERSION and CONFLUENT_VERSION as well. Sometimes, I run the kafka_test_setup directly. It will be great if you can bring the gradle version to the script.

Once the conflicts are resolved, I can approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants