Skip to content

change to new mirror, dry kafka version, better curl flags #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

change to new mirror, dry kafka version, better curl flags #198

wants to merge 3 commits into from

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jun 30, 2025 •
edited
Loading

Three concerns are mixed in this PR, I can split them into separate PRs if the reviewer so wishes:

  1. change the mirror from where to download kafka for testing
  2. DRY the kafka version location to ensure tests run with the same kafka broker version as the client
  3. use a better set of curl flags to maintain error messages and still avoid flooding ci logs with download progress

@jsvd jsvd force-pushed the change_mirror_location branch from 04b4ef1 to 7333ff8 Compare July 3, 2025 08:57
@jsvd jsvd force-pushed the change_mirror_location branch from 7333ff8 to 1d612ed Compare July 3, 2025 08:58
@jsvd jsvd marked this pull request as ready for review July 3, 2025 08:59
@jsvd jsvd requested a review from yaauie July 3, 2025 09:00
@jsvd jsvd changed the title change to new mirror change to new mirror, dry kafka version, better curl flags Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaauie yaauie Awaiting requested review from yaauie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsvd