Skip to content

Doc: Fix link to DLQ docs #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Jul 9, 2025

Replace intra-doc format link (<<dead-letter-queues>>) with link that will work across docs.
Now the link resolves correctly (ADOC).
Screenshot 2025-07-09 at 10 04 32 AM

@karenzone karenzone self-assigned this Jul 9, 2025
@karenzone karenzone added the docs label Jul 9, 2025
happens, the problem is logged as a warning, and the event is dropped. See
<<dead-letter-queues>> for more information about processing events in the DLQ.
happens, the problem is logged as a warning, and the event is dropped.
Check out https://www.elastic.co/guide/en/logstash/8.18/dead-letter-queues.html[Dead letter queues (DLQ)] for more information about processing events in the DLQ.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Is 8.18 intentional change here? If not maybe we change it with logstash-ref?

Suggested change
Check out https://www.elastic.co/guide/en/logstash/8.18/dead-letter-queues.html[Dead letter queues (DLQ)] for more information about processing events in the DLQ.
Check out {logstash-ref}/dead-letter-queues.html[Dead letter queues (DLQ)] for more information about processing events in the DLQ.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended to use current in the path. That link will redirect to the new docs.

{logstash-ref} would work for 8.x, too, but I'm trying to get away from using the old asciidoc attributes because they are different in MD.

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karenzone karenzone merged commit fc281c3 into logstash-plugins:main Jul 9, 2025
2 of 3 checks passed
@karenzone karenzone deleted the dlq-link branch July 9, 2025 17:50
@karenzone
Copy link
Contributor Author

Published at v12.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants