-
Notifications
You must be signed in to change notification settings - Fork 306
Doc: Fix link to DLQ docs #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/index.asciidoc
Outdated
happens, the problem is logged as a warning, and the event is dropped. See | ||
<<dead-letter-queues>> for more information about processing events in the DLQ. | ||
happens, the problem is logged as a warning, and the event is dropped. | ||
Check out https://www.elastic.co/guide/en/logstash/8.18/dead-letter-queues.html[Dead letter queues (DLQ)] for more information about processing events in the DLQ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Is 8.18 intentional change here? If not maybe we change it with logstash-ref
?
Check out https://www.elastic.co/guide/en/logstash/8.18/dead-letter-queues.html[Dead letter queues (DLQ)] for more information about processing events in the DLQ. | |
Check out {logstash-ref}/dead-letter-queues.html[Dead letter queues (DLQ)] for more information about processing events in the DLQ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intended to use current
in the path. That link will redirect to the new docs.
{logstash-ref}
would work for 8.x, too, but I'm trying to get away from using the old asciidoc attributes because they are different in MD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Published at v12.0.5 |
Replace intra-doc format link (

<<dead-letter-queues>>
) with link that will work across docs.Now the link resolves correctly (ADOC).