POC: Make the first three pistol perks (Magnum, Clutch Shot, and Quickdraw) purchasable without TC#1911
Open
DaloLorn wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Marked as draft, pending tests to be done later today. |
7700315 to
23ccbb5
Compare
…kdraw) purchasable without TC As with my other PR, conformance to LW's code style is questionable at best, but it *should* work.
23ccbb5 to
37345d9
Compare
Contributor
Author
|
Fixed a few syntax errors (hard and soft alike), and successfully completed all tests I could think of: ✅ Can successfully buy the perk without a Training Center (tested fresh out of Gatecrasher!) ✅ Also applies to other non-class rows, e.g. XCOM row (added NeedleGrenades to my test config) ✅ Does not apply to class rows (added SlugShot to my test config) ✅ Does not affect classes specified in ✅ Unless they are specified in Moving out of draft status. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





(Potentially resolves the eponymous thread, should the proposal be accepted for implementation.)
A proof-of-concept implementation of Suppression Spammer's proposal, allowing most classes to unconditionally spend AP on the Magnum, Quickdraw, and Clutch Shot perks if they appear in a non-class row (presumably, but not necessarily, the pistol row).
Due to a blend of laziness and caution, the configs for this feature can also be reused for any other non-class perks, with the following notes:
IGNORE_NO_TRAINING_CENTERarray.CLASSES_IGNORE_CUSTOM_COSTSarray, or added to a newCLASSES_ALLOW_NO_TRAINING_CENTERarray.As with my other PR, conformance to LW's code style is questionable at best, but it should work.