Skip to content

POC: Make the first three pistol perks (Magnum, Clutch Shot, and Quickdraw) purchasable without TC#1911

Open
DaloLorn wants to merge 1 commit into
long-war-2:masterfrom
DaloLorn:AllowFirstThreePistolPerksWithoutTC
Open

POC: Make the first three pistol perks (Magnum, Clutch Shot, and Quickdraw) purchasable without TC#1911
DaloLorn wants to merge 1 commit into
long-war-2:masterfrom
DaloLorn:AllowFirstThreePistolPerksWithoutTC

Conversation

@DaloLorn

@DaloLorn DaloLorn commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

(Potentially resolves the eponymous thread, should the proposal be accepted for implementation.)

A proof-of-concept implementation of Suppression Spammer's proposal, allowing most classes to unconditionally spend AP on the Magnum, Quickdraw, and Clutch Shot perks if they appear in a non-class row (presumably, but not necessarily, the pistol row).

Due to a blend of laziness and caution, the configs for this feature can also be reused for any other non-class perks, with the following notes:

  • The perk name must be specified in the IGNORE_NO_TRAINING_CENTER array.
  • The class name must either be omitted from the CLASSES_IGNORE_CUSTOM_COSTS array, or added to a new CLASSES_ALLOW_NO_TRAINING_CENTER array.
  • Again, for emphasis: The perk must be in a non-class row. Class perks are unaffected.

As with my other PR, conformance to LW's code style is questionable at best, but it should work.

@DaloLorn DaloLorn marked this pull request as draft November 28, 2025 12:34
@DaloLorn

Copy link
Copy Markdown
Contributor Author

Marked as draft, pending tests to be done later today.

@DaloLorn DaloLorn force-pushed the AllowFirstThreePistolPerksWithoutTC branch from 7700315 to 23ccbb5 Compare November 28, 2025 13:28
…kdraw) purchasable without TC

As with my other PR, conformance to LW's code style is questionable at best, but it *should* work.
@DaloLorn DaloLorn force-pushed the AllowFirstThreePistolPerksWithoutTC branch from 23ccbb5 to 37345d9 Compare November 28, 2025 14:50
@DaloLorn

Copy link
Copy Markdown
Contributor Author

Fixed a few syntax errors (hard and soft alike), and successfully completed all tests I could think of:

✅ Can successfully buy the perk without a Training Center (tested fresh out of Gatecrasher!)
✅ Does not override any other requirements (still need the AP to buy the perk!)

Detailsimage

✅ Also applies to other non-class rows, e.g. XCOM row (added NeedleGrenades to my test config)

Detailsimage

✅ Does not apply to class rows (added SlugShot to my test config)

Detailsimage

✅ Does not affect classes specified in CLASSES_IGNORE_CUSTOM_COSTS (added Ghostwalker to my test config)

Detailsimage

✅ Unless they are specified in CLASSES_ALLOW_NO_TRAINING_CENTER! (added Hitman and ShadowOps_FirstAid to my test config)

Detailsimage

Moving out of draft status.

@DaloLorn DaloLorn marked this pull request as ready for review November 28, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant