working with Requests1.1.0 #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I haven't had a chance to test this or look into the Requests changes yet, but thanks for the patch. There were a few problems that jumped out at me so I added comments inline... if you could fix those that would be great. |
|
ah ok, noticed. I always use tab when code in python, never realized that would be a problem. I'll take a look again later. basically i'm just replace the code so it will work on python latest requests module. i'm commenting out some code just for historical purpose. |
|
something wrong with my first commit, sorry. and also i've made it follow PEP8 standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issues 'instancemethod' object is not subscriptable (requests 1.1.0 use different approach)