fix: make filter work on count for consistency #10859
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
countendpoint generated with rest-crud has a where filter but doesn't havefilteritself.So
GET /count?where={"name":<name>}would work butGET /count?filter={"where":{"name":<name>}}will not work.I think this is intentional as the count endpoint would only require a where clause. But this causes inconsistency of filter in GET /count and
GET /andPATCH /.I am creating this draft PR to discuss if we add
filterto/counttoo in order to make it consistent with other endpoints.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈