-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update package locks #9545
Conversation
Signed-off-by: dhmlau <[email protected]>
Some tests failing. Not sure if those are due to this change or not. |
I have not seen this PR. I have merge a commit that fixes the update problem but it gives a problem in the Sequelize extension. |
It's failing here
It is a method of Sequelize. See https://sequelize.org/docs/v6/core-concepts/model-querying-finders/#findbypk |
I have found the problem. Sequelize creates a column of type array in INTEGER. That is what is giving problems. loopback-next/extensions/sequelize/src/sequelize/sequelize.repository.base.ts Lines 765 to 771 in c9c35c9
|
I have asked @shubhamp-sf to check it. |
@frbuceta It's actually the underlying package (sqlite3) upgrade in this PR that caused this issue. I've also reported the same on their repo, please go through the issue summary here: TryGhost/node-sqlite3#1694 I had reported this to @dhmlau in this renovate PR: #9367 (comment) cc: @samarpan-b |
Just raised a fix to use the working version of sqlite3 statically (until it gets fixed in the upstream) #9547 Also Diana, @frbuceta already pushed the lock maintenance 3 days back. Doesn't it already includes the changes this PR addresses? |
@samarpanB @shubhamp-sf, should we close this PR then? |
Ran
npm run update-package-locks
to update the package lock files.cc @samarpanB
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈