fix: use environment-based API URL for FeedbackModal requests - #682
Open
broskell wants to merge 1 commit into
Open
fix: use environment-based API URL for FeedbackModal requests#682broskell wants to merge 1 commit into
broskell wants to merge 1 commit into
Conversation
…lhost The FeedbackModal component had a hardcoded URL (http://localhost:5000) which would cause feedback submissions to fail silently when the backend is deployed to any environment other than localhost:5000. Changed to use process.env.REACT_APP_API_URL with a fallback, consistent with every other API-calling component in the codebase (AuthContext, Analytics, PYQs). Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
@broskell is attempting to deploy a commit to the Lovely Mahour's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the hardcoded backend URL in
FeedbackModalwith the existingREACT_APP_API_URLenvironment configuration used throughout the project.Problem
The feedback modal was making requests to a hardcoded endpoint:
This works only during local development and causes feedback submissions to fail in deployed environments.
Solution
REACT_APP_API_URL.Benefits
Files Changed
client/src/components/FeedbackModal.jsTesting
Checklist