fix: eliminate build warnings on Linux/Windows/macOS#91
Merged
Conversation
- Remove unused comp params in compressor callback functions - Fix constructor init list order in header (Wreorder) - Remove dead read_files_batched_legacy function - Cast block_size config fields to uint64_t (sign-compare) - Replace sprintf with snprintf in sha256.cpp (MSVC compat) - Fix unused argc/argv in io_overhead benchmark - ci: add macOS runner, submodules in checkout, test result artifacts
- Guard SSE4.2 intrinsics with x86/x64 arch check (fixes arm64-osx build) - Fix btree.hpp: friend struct -> friend class block_allocator - Fix format specifiers: %lu -> PRIu64 for uint64_t (macOS compat) - Fix test_data_integrity_strict.cpp: check fread return values Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix std::min type mismatch (size_t vs uint64_t) in test_insert_erase and test_library - Replace deprecated INSTANTIATE_TEST_CASE_P with INSTANTIATE_TEST_SUITE_P - Remove unused lambda captures in test_concurrency_stress and test_allocator_advanced - Remove unused file_size private field in optimal_usage benchmark - Fix fread return value ignored in test_data_integrity_strict - Fix SSE4.2 arch guard, btree friend class, PRIu64 format specifiers Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wreorder, sign-compare, dead code)sprintfwithsnprintfin sha256.cpp for MSVC compatibilitysubmodules: recursive, triplet-based cache keys, JUnit test result artifacts