-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Playwright E2E client coverage
#10466
base: develop
Are you sure you want to change the base?
Conversation
… reports for default test runs
…e problem is on coverage data itself on CI
# Conflicts: # src/test/playwright/package-lock.json # src/test/playwright/package.json # src/test/playwright/playwright.config.ts
This reverts commit db814e2.
… artemis-app container
…ck if the problem is on coverage data itself on CI" This reverts commit 67c12a9.
…esent in artemis-app container" This reverts commit 12bcab1.
… artemis-app container
# Conflicts: # src/test/playwright/package-lock.json # src/test/playwright/package.json
// Bamboo can upload only files as an artifact, not directories | ||
// That's why we archive the lcov coverage directory on CI to prepare it as an artifact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick note: since Bamboo will soon be removed, we’re actively migrating our E2E test runs to GitHub Actions. In a couple of weeks, the tests should be fully running here. After that, Helios will parse the final test results (results.xml
). So, IMO there’s not much value in adding any new Bamboo-specific functionality.
From what I can see, you’re still generating results.xml
as the final artifact in JUnit format, and that logic hasn’t changed—please correct me if I’m wrong.
Checklist
General
Client
Motivation and Context
It's not possible to understand how many percentage of the system is covered by E2E tests.
Description
This PR adds client code coverage for Playwright E2E tests. It's implemented using Playwright's own coverage feature and monocart-reporter for creating lcov reports.
Coverage information is generated automatically after test execution is finished. On CI, we zip and export the lcov coverage data as .zip archive.
Steps for Testing
src/test/playwright/test-reports
folder after test run is finished if running on headless mode or after UI is quit if running on UI mode.Steps for running the tests:
npm install && npm run playwright:setup
npm run playwright:test
to run all testsnpm run playwright:open
to open the Playwright UI and selectively run few testsTestserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests