Skip to content

Conversation

@FireInstall
Copy link
Collaborator

@FireInstall FireInstall commented Oct 6, 2024

closes #27

This switches from a class based system to group items together to a #tag system.
Two additional things come into play here:

  1. In order to fully replace the previous behavior, this depends on an update to at least 1.20.5, because of the newly added tags there.
  2. Tags are not loaded until a player joins a world (inclusive any server) or does some niche things like opening the create new world screen or optimizing an existing one.
    Since the mod ever comes into action once the player has successfully loaded in the game and doesn't have an ingame config this should be fine. But one should mind that in the menu screen the mod might not have loaded any config or maybe has obsolete values.
    Also using the vanilla /reload command also might alter the behavior of the mod. This is of course intentional, but should still be kept in mind.

@FireInstall
Copy link
Collaborator Author

FireInstall commented Oct 6, 2024

note, the build checks have failed, because of #28

Edit: fixed.

@FireInstall
Copy link
Collaborator Author

Also: If you had a look into my PRs and want to merge them all togther, hit me up!
I can pre-merge them for you resolving all conflicts.

@FireInstall FireInstall mentioned this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtime mappings

1 participant