Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-48511: Fix redis values configuration #4364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Fireye04
Copy link
Member

No description provided.

Copy link
Member

@afausti afausti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a KafkaTopic resource for backpack is the right move.
I've made a few suggestions to improve the configuration.

@Fireye04 Fireye04 requested a review from afausti March 31, 2025 23:04
Copy link
Member

@afausti afausti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the kafka.enabled flag being used?
Otherwise looks good.
Before merging, let me add the sasquatch-backpack namespace to the Strimzi configuration and check if this will work.

@afausti afausti self-requested a review April 1, 2025 22:50
Copy link
Member

@afausti afausti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that for this to work we would need to deploy the Strimzi topic operator in the sasquatch-backpack namespace.
I think I prefer specifying the KafkaTopic resource in Sasquatch itself, like we are doing with other applications that depend on Sasquatch.
Let's remove the KafkaTopic resource from backpack and I'll address this in DM-49745.
Sorry for the back and forth on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants