-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tickets/DM-48511: Fix redis values configuration #4364
base: main
Are you sure you want to change the base?
Conversation
2c296bf
to
49b9c74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a KafkaTopic resource for backpack is the right move.
I've made a few suggestions to improve the configuration.
ea9cf85
to
068bc0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the kafka.enabled
flag being used?
Otherwise looks good.
Before merging, let me add the sasquatch-backpack namespace to the Strimzi configuration and check if this will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that for this to work we would need to deploy the Strimzi topic operator in the sasquatch-backpack namespace.
I think I prefer specifying the KafkaTopic resource in Sasquatch itself, like we are doing with other applications that depend on Sasquatch.
Let's remove the KafkaTopic resource from backpack and I'll address this in DM-49745.
Sorry for the back and forth on this.
068bc0b
to
994e85c
Compare
No description provided.