-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-45988: Support storing init-outputs in Prompt Processing central repo #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspeck1
reviewed
Mar 28, 2025
dspeck1
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There a couple comments.
75addfd
to
f2e5a53
Compare
The initializer is a small-scale process that creates all the pipeline init-outputs that the main service might need, and commits them to the central repo exactly once. As such, it doesn't need much memory and no storage, but *must* run before the service is viable. The partial template allows the job definition to be shared between a Job and a CronJob, ensuring consistency.
The service does not currently use Sasquatch, but it could in principle send performance metrics.
The init service constructs all tasks in all pipelines, and PackageAlertsTask tries to connect to the Kafka server at construction time.
Rerunning the initializer daily is necessary because the run collection names include the day_obs (and this feature is very useful for anybody trying to analyze or reproduce the data later).
Knative HSC-gpu, LSSTCam, and LSSTComCam, and Keda LSSTComCam are currently unused.
The job needs to prepare version- and configuration-specific settings for the main service. By default, Argo only runs a job if no existing job object exists.
The service depends on the init job to correctly and self-consistently initialize the run collections for the day. Without the block, the service would receive visits but then fail during preprocessing.
f2e5a53
to
761967d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Job and CronJob that create init-outputs and output collections for the Prompt Processing service. By design, these jobs share much of their config with the primary service and must be updated together in order to work correctly.