-
Notifications
You must be signed in to change notification settings - Fork 0
OSW-666: Implement Context Feed #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
3b9be67
to
51aa6f1
Compare
7802f5e
to
8053b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a number of comments, but since I'm still new to JS I would prefer someone else's experienced approval, over my noticing of whitespace and small typos.
It feels like a shallow: LGTM
ad64ee7
to
73a2609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job @alserene 👏 ! This looks good, I left several comments and ideas for your consideration, but not strictly change request unless you agree with those 👍.
I have to say though that there were way too many comments for my taste 😅. I think there are some cases where you would require a more detailed comment e.g.:

And then we start thinking if having some docs for that would be better, but for now this is ok, is not necessary to re arrange them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one would be benefited of some refactoring in base to: https://react.dev/learn/you-might-not-need-an-effect, specifically by using what's detailed on Resetting all state when a prop changes.
f611a86
to
3586660
Compare
3586660
to
71cf793
Compare
PR for the Context Feed :)
Please merge the related backend PR first - #75.
Notes:
rubin_nights
in the future, but for now, we'll do it in the front end.