DM-48279: APDB simulation #263
Conversation
andy-slac
left a comment
andy-slac
left a comment
There was a problem hiding this comment.
Few general comments, and I did not read the whole thing.
| " detected per square degree. For this simulation, these will" | ||
| " always be detected, and detected in the same location." | ||
| "The default is chosen such that:" | ||
| " Density x Rubin Fov (9.6) x # of visits per night (~600) ~ 10M", |
There was a problem hiding this comment.
I think LDM-141 specifies average of 1000 visits per night?
| default=4, | ||
| doc="Average ratio of false detections to real sources." | ||
| "These will be detected in random locations.", |
There was a problem hiding this comment.
LDM-141 expects false positives to be 50% of real alerts, if the actual number is 400%, do we need to update LDM-141?
There was a problem hiding this comment.
Good question, since we are nowhere close to 2:1 real to bogus sources currently. This ratio is over a year old, though, and has not been re-evaluated from ComCam data.
| default=10, | ||
| doc="Area (in degrees) of the simulated survey", |
There was a problem hiding this comment.
Hmm, with the area so small the distribution across spatial partitions will be very uneven, that will likely cause uneven load across Cassandra cluster.
There was a problem hiding this comment.
Yes, this was just for testing. The actual value will be 18000.
| difference and direct images at DiaObject locations. | ||
| """ | ||
| # Restrict forced source measurement to objects with sufficient history to be reliable. | ||
| objectTable = diaObjects.query(f'nDiaSources >= {self.config.historyThreshold}') |
There was a problem hiding this comment.
Hmm, this depends on nDiaSources being correct and that depends on having DiaSource history.
There was a problem hiding this comment.
Yes, this is the one place I currently use the diaSource history. I will attempt to re-write it without needing that history, so that I can skip reading diaSources.
isullivan
force-pushed
the
tickets/DM-48279
branch
2 times, most recently
from
7b236ab to
9ab4ece
Compare
isullivan
force-pushed
the
tickets/DM-48279
branch
3 times, most recently
from
d49e000 to
3ffec1a
Compare
Before many diaObjects were being missed, now they are all correctly loaded
Do not write preloaded diaObjects that were not associated with new diaSources
isullivan
force-pushed
the
tickets/DM-48279
branch
from
3ffec1a to
2d74cfc
Compare
No description provided.