DM-52371: Unnecessary serialization during query parsing, analysis and registration in Qserv #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgates108
commented
Sep 5, 2025
|
|
||
| /// Protects CSS in `qs->analyzeQuery(query, stmt);` and | ||
| /// protects uq calls that alter the database. | ||
| std::mutex _factoryMtx; |
There was a problem hiding this comment.
CSS and all of these other things should be made thread safe, but that's a much bigger job and CSS is about to be under the microscope for other reasons in the next couple of weeks.
fritzm
force-pushed
the
tickets/DM-52371
branch
from
084a5cb to
c90ad56
Compare
fritzm
changed the title
fritzm
force-pushed
the
tickets/DM-52371
branch
3 times, most recently
from
2d1f082 to
b1554b4
Compare
fritzm
force-pushed
the
tickets/DM-52371
branch
2 times, most recently
from
b4da445 to
23c43f8
Compare
fritzm
force-pushed
the
tickets/DM-52371
branch
from
23c43f8 to
b737974
Compare
fritzm
force-pushed
the
tickets/DM-52371
branch
from
b737974 to
1936a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.