-
Notifications
You must be signed in to change notification settings - Fork 1
SP-2381: update firefly NB #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Shenming, my review is available as #81. The new sections didn't fit very well with what was already there, so I rearranged it to work with the established flow of the notebook. This required some changes to the screenshot but otherwise it's pretty much the same content.
For the FireflyClient I added how this is basically an instance of the Portal and linked to the Portal resources.
Once you merge my PR 81 into your branch, make any final tweaks in your branch (and do a final flake8 check), so long as the checks on your PR 79 are passing you're OK to merge. If there are any new issues just let me know.
u/mlg/2025-09-30/SP-2381-review: revise the order
Thank you so much Melissa! I've merged your PR 81 into my branch. |
Final tweaks and the final flake8 check were done. Ready to merge. |
Added methods: zooming and displaying frames side by side.