Add FastAPI tutorial #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
cwebster-99
reviewed
Oct 16, 2023
* Adding formatter table * adding changes * Update docs/python/formatting.md Co-authored-by: Karthik Nadig <[email protected]> * Update docs/python/formatting.md * Update docs/python/formatting.md Co-authored-by: Luciana Abud <[email protected]> * Adding import sorting extensions table * Adding setup instructions for import sorting * typo * fixing more typos * On save sentence * adding workspace settings --------- Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
luabud
commented
Oct 19, 2023
debonte
reviewed
Oct 20, 2023
debonte
reviewed
Oct 21, 2023
docs/python/tutorial-fastapi.md
Outdated
| ``` | ||
| And replace it with: | ||
| ```python | ||
| item_id = redis_client.hget("item_name_to_id", item.item_name) |
There was a problem hiding this comment.
The amount of red squiggles that showed up after this change made me uncomfortable. I wonder if there's a more incremental approach we could take to these changes?
Co-authored-by: Erik De Bonte <[email protected]>
Co-authored-by: Erik De Bonte <[email protected]>
cwebster-99
reviewed
Oct 23, 2023
cwebster-99
reviewed
Oct 23, 2023
cwebster-99
reviewed
Oct 23, 2023
cwebster-99
reviewed
Oct 23, 2023
cwebster-99
reviewed
Oct 23, 2023
cwebster-99
reviewed
Oct 23, 2023
cwebster-99
reviewed
Oct 23, 2023
* Add browser version info * feedback
cwebster-99
reviewed
Oct 23, 2023
debonte
reviewed
Oct 23, 2023
debonte
reviewed
Oct 23, 2023
debonte
reviewed
Oct 24, 2023
Co-authored-by: Erik De Bonte <[email protected]>
|
Can't thank @debonte and @cwebster-99 enough for all the feedback! I think I solved the biggest problems in this PR so I'll open it on the docs repo to get more eyes on it: https://github.com/microsoft/vscode-docs/pull/6760/files. If you find more things that can be improved please feel free to keep adding comments, it's been extremely helpful! |
* scaffold new Custom Layout topic * Locked editor group basics Part of microsoft#6568 * add a couple of images * Add Panel alignment section and image * Add more sections * Locked editor groups * Add pinned tab image * avoid a line break --------- Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]> Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of the tutorial is in the
docs/python/tutorial-fastapi.mdfile.