Update ansi.luau #160
Open
Update ansi.luau #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicell
reviewed
Apr 21, 2025
batteries/colorful.luau
Outdated
Comment on lines
6
to
8
| local function colorDisabled(): boolean | ||
| -- is it really okay to index env every style call? | ||
| return process.env.NO_COLOR ~= nil |
There was a problem hiding this comment.
I'd suggest looking at how picocolors handles NO_COLOR. it also returns a generator function where you can explicitly specify if you want colors or not (but default returns the inferred preference) https://github.com/alexeyraspopov/picocolors/blob/main/picocolors.js
There was a problem hiding this comment.
Yeah, I think it'd be reasonable to return a function here, e.g.
function(colorsEnabled: boolean?)
local colorsEnabled = colorsEnabled or (process.env.NO_COLOR ~= nil)
return ...
end
Nicell
reviewed
Apr 21, 2025
Nicell
reviewed
Apr 21, 2025
aatxe
reviewed
Apr 21, 2025
aatxe
requested changes
May 4, 2025
Co-authored-by: ariel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combine(...), looks likecombine(colorful.red, colorful.bold)("This is red bold text!")