Skip to content

Add stdio option to process.run #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025
Merged

Conversation

Nicell
Copy link
Collaborator

@Nicell Nicell commented Apr 24, 2025

We need a way to inherit stdout/stderr with process.run to finish #171.

This adds support for default inherit and none options for stdio. Default buffers the output and returns stdout/stderr in the result table. Inherit uses the parent process stdout/stderr (needed for luthier). None just ignores stdout/stderr from the created process.

In the future it'd be great to:

  • Add a forward stdio kind that both buffers the output and forwards it to the parent process stdout/stderr
  • Support different kinds for stdout vs stderr and also support a string/buffer in for stdin

@Nicell Nicell changed the title Add stdio inherit to process.create Add stdio option to process.create Apr 26, 2025
@Nicell Nicell marked this pull request as ready for review April 26, 2025 00:54
@Nicell Nicell requested a review from aatxe April 28, 2025 04:01
@Nicell Nicell changed the title Add stdio option to process.create Add stdio option to process.run Apr 28, 2025
@aatxe aatxe merged commit 128db4a into luau-lang:primary Apr 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants