refactor: use AsyncResult accessors instead of manual result inspection#95
Merged
Conversation
lucas-barake
force-pushed
the
refactor/async-result-accessors
branch
from
July 10, 2026 02:38
3105b7f to
9c792a2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces hand-rolled inspection of
AsyncResultvalues inFormAtoms.tswith the accessors effect v4 already ships ineffect/unstable/reactivity/AsyncResult:displayErrorAtom: the manual_tag === "Failure"+Cause.findErrorOption+Schema.isSchemaErrorblock collapses toOption.flatMap(AsyncResult.error(validationResult), Validation.extractFirstError).AsyncResult.erroris exactlyself._tag === "Failure" ? Cause.findErrorOption(self.cause) : Option.none(), and the validation atom's error channel is staticallySchema.SchemaError, so theisSchemaErrorre-guard was redundant._tag === "Success"→AsyncResult.isSuccess..waitingreads (displayErrorAtom,isValidating,autoSubmitAtom,onBlurSubmitAtom) →AsyncResult.isWaiting.Causeimport.Behavior
No behavior change. Added one focused test locking the previously untested branch: a stored
field-source error is hidden while validation is re-running (waiting), alongside the existing test covering the validation-success case.Verification
pnpm check:typescleanpnpm vitest run: 302 tests passed (9 files)pnpm lintclean