Skip to content

Conversation

@bcardiff
Copy link
Contributor

@bcardiff bcardiff commented Jul 31, 2019

A Crystal::VERSION check around URI.encode_www_form should be added if you want lucky to be warning free but also keep working in 0.29.0.

You can double-check in crystal-lang/crystal#7997 which encode/decode method applies better.

A couple of dependencies need to be updated also as stated in bcardiff@053b559 after each of them are released. Do not use my forks as dependencies.

There is one fix I notice along the way regarding distance_in_days.

Feel free to use as-is or close and use as a reference.

Thanks for all the specs that helped us discovering crystal-lang/crystal#8020 before releasing.

@jwoertink
Copy link
Member

Awesome! Thanks for all your efforts!

@paulcsmith
Copy link
Member

Thanks :D I removed the CLI and other mosop deps from paulcsmith/cry since we weren't using those libs anyway.

Rebased and added a new commit in #859

@paulcsmith paulcsmith closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants