Fix make_admin_user command
#1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Feb 27, 2025
michplunkett
requested review from
AetherUnbound,
abandoned-prototype and
sea-kelp
michplunkett
commented
Feb 28, 2025
| @@ -356,6 +356,7 @@ def test_image_classification_and_tagging(browser, server_port, session): | |||
| browser.find_element(By.ID, "last_name").send_keys("Friendly") | |||
| browser.find_element(By.ID, "star_no").send_keys(star_no) | |||
|
|
|||
| wait_for_element(browser, By.ID, "submit") | |||
There was a problem hiding this comment.
Takes care of a race condition that was causing this test to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#1160
Description of Changes
Changed
confirmedfield toconfirmed_atandconfirmed_byand added a validating test.Tests and Linting
developbranch.make create_db_diagramcommand.pytestpasses on my local development environment.pre-commitpasses on my local development environment.