Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make_admin_user command #1161

Merged
merged 11 commits into from
Feb 28, 2025
Merged

Fix make_admin_user command #1161

merged 11 commits into from
Feb 28, 2025

Conversation

michplunkett
Copy link
Collaborator

@michplunkett michplunkett commented Feb 27, 2025

Fixes issue

#1160

Description of Changes

Changed confirmed field to confirmed_at and confirmed_by and added a validating test.

Tests and Linting

  • This branch is up-to-date with the develop branch.
  • Ran make create_db_diagram command.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett self-assigned this Feb 27, 2025
@michplunkett michplunkett linked an issue Feb 27, 2025 that may be closed by this pull request
@michplunkett michplunkett marked this pull request as ready for review February 27, 2025 22:03
Copy link
Collaborator

@sea-kelp sea-kelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -356,6 +356,7 @@ def test_image_classification_and_tagging(browser, server_port, session):
browser.find_element(By.ID, "last_name").send_keys("Friendly")
browser.find_element(By.ID, "star_no").send_keys(star_no)

wait_for_element(browser, By.ID, "submit")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes care of a race condition that was causing this test to fail.

@michplunkett michplunkett merged commit 8decbce into develop Feb 28, 2025
4 checks passed
@michplunkett michplunkett deleted the fix-new-user branch February 28, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix make_admin_user command
2 participants