This repository was archived by the owner on Mar 10, 2019. It is now read-only.
Fix objj2 warnings #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added LPMultiLineTextField.j import to LPKit.j. Importing the framework with @import <LPKit/LPKit.> would also import LPMultiLineTextField as well.
Updated Jakefile to use new template. Kept original license an and author settings.
Added import for <AppKit/CPApplication.j> to provide global variable "CPApp".
- (void)mouseUp:(CPEvent)anEvent declared a local var "calenderView" which hid the ivar of the same name. Replaced the local var with "theCalenderView". Although it might also work to not define an additonal variable but simply refer to the ivar.
The initial assignment of _firstDay with missing a var statement.
The initial assignment of _cached with missing a var statement.
- (void)setDisplayLabels:(BOOL)shouldDisplayLabels referenced a non-existent (local) var aFrame. I assume aFrame references the size of the drawView. BREAKING CHANGE: Although this code would have thrown an error anyway this should be marked as breaking as I do not fully understand the original intention here. My "fix" might be incorrect from a intention point of view.
The initial assignment of itemFrames with missing a var statement.
The initial assignment of numberOfSubviews with missing a var statement.
The initial assignment of frameIsDirty with missing a var statement.
The initial assignment of key with missing a var statement.
The initial assignment of isHighlighted with missing a var statement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all the warnings caused by the new Obj-J 2 compiler. Updates the Jakefile to the current capp template.