Remove calderacc/geobasic and replace with local Geo classes #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltehuebner
added
enhancement
dependencies
maltehuebner
force-pushed
the
remove-geobasic
branch
from
34a7288 to
ef7f1c3
Compare
Introduce App\Geo\Coord\{Coord,CoordInterface} and
App\Geo\Coordinate\{Coordinate,CoordinateInterface} as local
replacements for the external calderacc/geobasic package.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace all Caldera\GeoBasic\Coord and Caldera\GeoBasic\Coordinate imports across 22 files (src and tests) with the new local App\Geo namespace. Remove calderacc/geobasic from composer.json. The package had a problematic phpunit runtime dependency and was unmaintained since 2021. The local replacement provides identical functionality without external dependencies. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
maltehuebner
force-pushed
the
remove-geobasic
branch
from
ef7f1c3 to
eba4027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
App\Geo\Coord\{Coord,CoordInterface}andApp\Geo\Coordinate\{Coordinate,CoordinateInterface}as drop-in replacements for the externalcalderacc/geobasicpackageCaldera\GeoBasic\*imports acrosssrc/andtests/with the newApp\Geo\*namespacecalderacc/geobasicfromcomposer.json— the package was unmaintained (last release 2021) and had a problematic phpunit runtime dependencyTest plan
composer installcompletes without errors🤖 Generated with Claude Code