Fix refreshMaterializedView() to refresh all views #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $sql variable was overwritten three times, so only the last REFRESH (current_data) was ever executed. data_view and silvester_data were never refreshed. Use separate executeStatement() calls instead. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
current_datamaterialized view was refresheddata_viewandsilvester_datawere never refreshed due to$sqlvariable being overwrittenexecuteStatement()instead of native queries for DDL statementsProblem
Test plan
php bin/console luft:refreshand verify all three views are refreshed🤖 Generated with Claude Code