Skip to content

Add null-safe operator to Data::getProvider() #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maltehuebner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add null-safe operator to Data::getProvider() #466

maltehuebner wants to merge 1 commit into from

Conversation

@maltehuebner
Copy link
Contributor

@maltehuebner maltehuebner commented Feb 8, 2026

Summary

  • Use nullsafe operator (?->) in Data::getProvider() to prevent TypeError

Problem

Data::station is typed as ?Station (nullable), but getProvider() called $this->station->getProvider() directly. This crashes when station is null, e.g. for adhoc Data objects created by AdhocDataRetriever.

Test plan

  • Verify pages rendering Data objects without stations don't crash
  • Verify station detail pages still show the provider

🤖 Generated with Claude Code

@maltehuebner @claude
Add null-safe operator to Data::getProvider()
1b0ebe5 
The station property is nullable, but getProvider() called
\$this->station->getProvider() without a null check. This could cause
a TypeError for adhoc Data objects created without a persisted station.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maltehuebner