Fix coordinate order in Station constructor #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostGIS POINT geometry expects (longitude, latitude) but the constructor wrote POINT(latitude, longitude). The prePersist() lifecycle callback had the correct order, but the constructor did not. This affected adhoc Station objects created in AdhocDataRetriever which are never persisted and thus never corrected by prePersist(). Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(latitude, longitude)to(longitude, latitude)Problem
PostGIS expects
POINT(longitude latitude)([x y] convention), but the Station constructor wrotePOINT(latitude longitude). TheprePersist()lifecycle callback had the correct order, so persisted stations were fine — but adhoc Station objects (created inAdhocDataRetrieverfor real-time OWM data) were never persisted, so theircoordfield had swapped coordinates.Test plan
🤖 Generated with Claude Code