-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no color option #114
base: master
Are you sure you want to change the base?
Add no color option #114
Conversation
Added the color option, and also reorganized the command line parameters to make them easier to review in code.
To align to British spelling, per the pipeline tests.
Changed the parameter to --no-colour and updated the docs/code as appropriate, so it would pass the pipeline spell check. :) |
I also notice on the README you said the next major version may switch to US English? If so, I can a) put color back, and b) update the pipeline to force english spell checking, which should allow it to pass the CI. |
@lukeapage Could this please be merged? It would be very helpful |
Hello and thanks for all of this work! As an end user, I'm giving a 👍 to this feature. Not only this spellchecker is NEAT, but also this feature ! |
This merge would be so incredibly helpful, I don't suppose it could be merged in @robatwilliams or @lukeapage? |
Fixes #36. This is an attempt to add the command line parameter to support no color mode.
[[[mistaeks]]]
.Two outstanding questions for feedback:
I couldn't find any CONTRIBUTING guidelines, so I am simply submitting straight into
master
. Hope that's ok!