fix(tabs): onChange callback type definition #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomoto-hitachi
force-pushed
the
fix/tabs-type-definition
branch
from
f2664de to
e8fc35b
Compare
zettca
approved these changes
Dec 17, 2020
francisco-guilherme
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, this is a minor type definition fix of
HvTabsProps.onChange.Issue
You get this error when passing
onChangehandler toHvTabs.Analysis
It appears an issue of MUI 4, which they admit but will not fix as they are now focusing on MUI 5.
mui/material-ui#17454
Solution
Based on the discussion in the thread above, explicitly declaring
onChangehandler with the event typeReact.SyntheticEvent(parent class of ChangeEvent, FormEvent, etc.) can workaround the issue.