Skip to content
This repository was archived by the owner on Jun 15, 2019. It is now read-only.

Conversation

@patcon
Copy link
Contributor

@patcon patcon commented Oct 25, 2018

Addresses #12

@patcon
Copy link
Contributor Author

patcon commented Oct 25, 2018

Using numeric sort key so we know that the order of execution is the same, and allow people to choose where to insert their processing. Untested for now, but I'll start using it on my production app, and will confirm working

@lunny
Copy link
Owner

lunny commented May 17, 2019

This will break the usage of the function.

@patcon
Copy link
Contributor Author

patcon commented May 17, 2019

Thanks for looking at this PR lunny! You're right, it's a breaking change and major version-bump as-is. Do you have a rough idea how you'd like to see backward compat preserved? (i'm a bit unsure what the norms are in golang)

If you have no immediate thoughts, that's ok too. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants