Clarify SSR Docs #185
Open
Clarify SSR Docs #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2024 18:20
Clairfying this feature has caused the feature list flow to read differently, so other minor adjustments were made
|
I like this, this is a good tweak IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the Lustre guide, I mistook the
Server Side Renderingpage as the only way to do SSR, and then didn't continue to read Server Components.This PR remedies this by changing the three main places in which a potential user is introduced to SSR: the features section in the readme, and the two relevant guides.
For the readme, I've changed the features more for the new phrasing to flow better with the rest of them, feel free to change yourself or ask for changes.
For the guides, I've clearly separated the two modes of SSR, but the naming is still a bit confusing. I would at the very least change "Server Side Rendering" to more specific title, although I could not come up with one.