Fixes for double #1302
Open
Fixes for double #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Pandapip1
reviewed
May 1, 2025
| @@ -26,7 +26,8 @@ struct Color { | |||
| Color(float r, float g, float b, float a) { | |||
| // r,g,b,a values should be in range [0.0, 1.0] | |||
| auto check = [](float val) -> float { | |||
| if(val < 0.0 || val > 1.0) { | |||
| const float epsilon = 1e-6f; | |||
| if(val < (0.0f - epsilon) || val > (1.0f + epsilon)) { | |||
There was a problem hiding this comment.
Comparisons to 0 and 1 should be fine since they can be represented exactly as an IEEE float, no?
There was a problem hiding this comment.
As far as I'm aware, C++ doesn't specify a binary float representation format.
There was a problem hiding this comment.
It does, IIUC. C++ uses C types, and C specifies IEEE 754 for floating point integers. This is actually not true, it's just that all the compilers use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweaks around floating point numbers that gave warnings during compilation.