-
Notifications
You must be signed in to change notification settings - Fork 0
feat: generate_script_content update #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
===========================================
+ Coverage 31.84% 53.99% +22.14%
===========================================
Files 53 85 +32
Lines 3074 5078 +2004
===========================================
+ Hits 979 2742 +1763
- Misses 2095 2336 +241 ☔ View full report in Codecov by Sentry. |
The |
Agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Platform differentiation in the
generate_script_content
function is not necessary anymore because we can now utilizeImageManipConfigV2
both for RVC2 and RVC4.Specification
generate_script_content
function:cfg_content
creation,resize_mode
setting;unittests/test_nodes/test_host_nodes/test_detection_config_generator.py
na rename it totest_generate_script_content.py
Dependencies & Potential Impact
Removing the
platform
parameter from thegenerate_script_content
function will cause some disturbances. Thankfully, none of the examples indepthai-experiments
imports this function (but they rather use custom implementations).Deployment Plan
None
Testing & Validation
Running the updated
human-pose
experiment (HERE) on RVC2.