Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ifDraw2d method drawTransformedObject() #272 #275

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

lvcabral
Copy link
Owner

The behavior, when scaleX and scaleY are not the same value is different from Roku.

  • In Roku the object is rotated first, then scaled.
  • In brs-engine the object is scaled then rotated.

This will be fixed in a future ticket.

Copy link

sonarqubecloud bot commented Feb 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.4% Duplication on New Code (required ≤ 20%)

See analysis details on SonarCloud

@lvcabral lvcabral merged commit 6e00174 into master Feb 20, 2024
2 of 3 checks passed
@lvcabral lvcabral deleted the implement-ifdraw2d-drawtransformedobject branch March 9, 2024 22:46
lvcabral added a commit that referenced this pull request Mar 28, 2025
* Fixed #272 - Implement undocumented `ifDraw2D` method `DrawTransformedObject`

* Updated test files to use downloaded assets

* Extracted drawRotateObject to draw2d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant