Skip to content

feat: link with g2d and generate wayland dmabuf protocols #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

anaGrad
Copy link

@anaGrad anaGrad commented May 16, 2025

Hi @kisvegabor @AndreCostaaa!
This PR comes along with the one on LVGL #8122. It aims to add all the necessary libraries and files to CMake and wl_protocols, but also reflect the changes made to the function lv_wayland_timer_handler()

@anaGrad anaGrad force-pushed the feature/g2d-optimization branch 2 times, most recently from 085deed to d4eada2 Compare May 16, 2025 11:13
@cosmindanielradu19 cosmindanielradu19 force-pushed the feature/g2d-optimization branch 3 times, most recently from 7182f4e to 9f83a68 Compare June 2, 2025 12:14
anaGrad and others added 4 commits June 2, 2025 15:18
Signed-off-by: Ana Grad <[email protected]>
Signed-off-by: Cosmin Radu <[email protected]>
Signed-off-by: Prabhu Sundararaj <[email protected]>
Signed-off-by: Cosmin Radu <[email protected]>
Signed-off-by: Ana Grad <[email protected]>
Signed-off-by: Cosmin Radu <[email protected]>
Signed-off-by: Cosmin Radu <[email protected]>
@@ -2,7 +2,7 @@
# Generate wayland xdg shell protocol

OUTPUT_DIR="$1"
PROTOCOL_ROOT="${SYSROOT:-}/usr/share/wayland-protocols"
PROTOCOL_ROOT="${SDKTARGETSYSROOT:-}/usr/share/wayland-protocols"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe SYSROOT is more generic for other platforms. Doesn't nxp support it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDKTARGETSYSROOT is the one that comes from the toolchain

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep this as SYSROOT since it's more generic and will cover more use-cases down the line. What do you think ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check one more time what env vars are set on the toolchain, and I'll come back with an answer / alternative.

Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cosmindanielradu19 and @anaGrad

So I just checked and indeed, the sdk exports SDKTARGETSYSROOT and not SYSROOT
I also found that a OEToolchainConfig.cmake exists inside the SDK and thus we could pass the current CMAKE_SYSROOT as an argument to the script

So I was thinking that we could either use the CMAKE_SYSROOT variable when invoking the script and basically it would be mandatory to call cmake like this:

cmake -B build -DCMAKE_TOOLCHAIN_FILE=$OECORE_NATIVE_SYSROOT/usr/share/cmake/OEToolchainConfig.cmake

OR option 2 would be check for both SYSROOT and SDKTARGETSYSROOT and produce an error if both are set

I'm tending more towards option 2 as it's the easiest and more beginner friendly approach

What do you think ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with option 2 as well

@AndreCostaaa AndreCostaaa changed the title G2D Optimization feat: link with g2d and generate wayland dmabuf protocols Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants