-
Notifications
You must be signed in to change notification settings - Fork 201
feat: link with g2d and generate wayland dmabuf protocols #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
085deed
to
d4eada2
Compare
7182f4e
to
9f83a68
Compare
Signed-off-by: Ana Grad <[email protected]> Signed-off-by: Cosmin Radu <[email protected]>
Signed-off-by: Prabhu Sundararaj <[email protected]> Signed-off-by: Cosmin Radu <[email protected]>
Signed-off-by: Ana Grad <[email protected]> Signed-off-by: Cosmin Radu <[email protected]>
Signed-off-by: Cosmin Radu <[email protected]>
@@ -2,7 +2,7 @@ | |||
# Generate wayland xdg shell protocol | |||
|
|||
OUTPUT_DIR="$1" | |||
PROTOCOL_ROOT="${SYSROOT:-}/usr/share/wayland-protocols" | |||
PROTOCOL_ROOT="${SDKTARGETSYSROOT:-}/usr/share/wayland-protocols" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe SYSROOT is more generic for other platforms. Doesn't nxp support it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDKTARGETSYSROOT is the one that comes from the toolchain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep this as SYSROOT
since it's more generic and will cover more use-cases down the line. What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check one more time what env vars are set on the toolchain, and I'll come back with an answer / alternative.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cosmindanielradu19 and @anaGrad
So I just checked and indeed, the sdk exports SDKTARGETSYSROOT
and not SYSROOT
I also found that a OEToolchainConfig.cmake
exists inside the SDK and thus we could pass the current CMAKE_SYSROOT
as an argument to the script
So I was thinking that we could either use the CMAKE_SYSROOT variable when invoking the script and basically it would be mandatory to call cmake like this:
cmake -B build -DCMAKE_TOOLCHAIN_FILE=$OECORE_NATIVE_SYSROOT/usr/share/cmake/OEToolchainConfig.cmake
OR option 2 would be check for both SYSROOT
and SDKTARGETSYSROOT
and produce an error if both are set
I'm tending more towards option 2 as it's the easiest and more beginner friendly approach
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with option 2 as well
Signed-off-by: Ana Grad <[email protected]>
Hi @kisvegabor @AndreCostaaa!
This PR comes along with the one on LVGL #8122. It aims to add all the necessary libraries and files to CMake and wl_protocols, but also reflect the changes made to the function
lv_wayland_timer_handler()