Skip to content

incusd/server/device/nic_routed: Added host_tables #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025

Conversation

AbhinavTiruvee
Copy link

We closed our old PR (#1964) and are opening a new one due to it being pretty outdated compared to the codebase. We added our changes to nic_routed.go and wanted to know where else we need to edit. We assume the documentation we need to add would be through gendoc and we would mark the ipv4.host_table and ipv6.host_table as deprecated there.

Issue #1559

@avipatel805 avipatel805 force-pushed the hostTables branch 6 times, most recently from b152c0f to d30c45f Compare April 27, 2025 23:48
@stgraber
Copy link
Member

A few small changes seem needed:

  • I'd split the addition of the new logic with marking the old options as deprecated
  • The commit with the deprecation notice should also change the doc string (gendoc)
  • You need to add a commit (typically titled doc: Update configs) with the result of make update-metadata
  • As this adds new config keys, an API extension should be added, this is done by editing both doc/api-extensions.md and internal/version/api.go, in this case, the string may be something like instance_nic_routed_host_tables

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Apr 28, 2025
@avipatel805 avipatel805 force-pushed the hostTables branch 3 times, most recently from d543418 to 32af39b Compare April 28, 2025 05:14
@avipatel805
Copy link
Contributor

We seem to be passing all test cases except for a spellcheck on "ipv." Is this something we should change, or is it okay?

@stgraber stgraber changed the title incus/server/device/nic_routed/go: Added host_tables incusd/server/device/nic_routed: Added host_tables Apr 30, 2025
@stgraber stgraber merged commit e9c5323 into lxc:main Apr 30, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Development

Successfully merging this pull request may close these issues.

3 participants