Skip to content

Rewrite legacy QEMU config code #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Rewrite legacy QEMU config code #2011

wants to merge 5 commits into from

Conversation

bensmrs
Copy link
Contributor

@bensmrs bensmrs commented Apr 28, 2025 •
edited
Loading

No description provided.

@bensmrs bensmrs requested a review from stgraber as a code owner April 28, 2025 01:39
@bensmrs bensmrs marked this pull request as draft April 28, 2025 01:53
@bensmrs bensmrs marked this pull request as ready for review April 28, 2025 02:22
@bensmrs
Copy link
Contributor Author

bensmrs commented Apr 28, 2025 •
edited
Loading

Now that I’m using maps, memoryConfigSectionToMap iterates in an arbitrary order over the host-nodes.X keys, making the test fail sometimes. Is the order important here?

@stgraber
Copy link
Member

I wouldn't expect the order to be meaningful, no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensmrs @stgraber