-
-
Notifications
You must be signed in to change notification settings - Fork 297
Add support for split image publishing #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I've made all of the changes needed to fix the static analysis failing. I was wondering how I should do the commits for the changes - i.e. should I format the commits like regular commits (with one for every file changed) or should I put all the changes into one commit or should I do something different. I just want to make sure everything is formatted correctly |
055fdf3
to
6ec20c3
Compare
cb16065
to
b01a01b
Compare
Signed-off-by: Stéphane Graber <[email protected]>
b01a01b
to
e10de42
Compare
Signed-off-by: Saahir Narang <[email protected]>
…ng to split images Signed-off-by: Saahir Narang <[email protected]>
…ainers Signed-off-by: Saahir Narang <[email protected]>
Signed-off-by: Saahir Narang <[email protected]>
Signed-off-by: Saahir Narang <[email protected]>
Signed-off-by: Saahir Narang <[email protected]>
e10de42
to
a9cc4d0
Compare
stgraber
approved these changes
May 3, 2025
a9cc4d0
to
f9559a8
Compare
Signed-off-by: Saahir Narang <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
f9559a8
to
69f68ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #871
Signed-off-by: Saahir Narang [email protected], Harshadeep Kambhampati [email protected]