incusd: remove unreachable code in api internal #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a conditional check in the api_internal.go where instName was checked to be not the empty string. This is always true since at the top of the function it is already checked and an error returned in that case. Signed-off-by: karo <[email protected]>
Changes a comment that was referencing a no longer existing option that was removed in 14a5882. Signed-off-by: karo <[email protected]>
Removes code in the internalImportFromBackup function that was unreachable since the same condition further up leads to a return of the function. Signed-off-by: karo <[email protected]>
Removes code in the internalImportFromBackup function that was unreachable since the same condition further up leads to a return of the function. Signed-off-by: karo <[email protected]>
The127
commented
Apr 28, 2025
stgraber
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unrechable code in cmd/incud/api_internal.go and also updates an outdated comment .